Skip to content

fix: Various manual fixes/tweaks in preparation for clang-tidy PR#415

Merged
dbanks12 merged 7 commits into
masterfrom
db/clang-format-tidy-setup
Apr 29, 2023
Merged

fix: Various manual fixes/tweaks in preparation for clang-tidy PR#415
dbanks12 merged 7 commits into
masterfrom
db/clang-format-tidy-setup

Conversation

@dbanks12

@dbanks12 dbanks12 commented Apr 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Blocks #393

  • Adds clang-format/clang-tidy/clangd configuration files and a helper script for tidying
  • Fixes code that actually breaks clang-tidy (auto-fixes lead to compilation errors without these manual fixes)

The purpose of this intermediate/separate PR is that individuals can merge just this patch into their branches so they can then run clang-tidy successfully to relieve some pains when trying to merge the larger refactor which is coming next.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad

ludamad commented Apr 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

LGTM (so far)

@dbanks12 dbanks12 marked this pull request as ready for review April 29, 2023 15:23
@dbanks12

dbanks12 commented Apr 29, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @ludamad. Just flagged it as ready after pushing the actual clang-format/clang-tidy/clangd configurations and the script for tidying. This PR fixes code that actually breaks clang-tidy (auto-fixes lead to compilation errors without these manual fixes).

The purpose of this intermediate/separate PR is that you/others can merge just this patch into your branches so you can then run clang-tidy successfully to relieve some pains when trying to merge the larger refactor which is coming next.

@dbanks12 dbanks12 mentioned this pull request Apr 29, 2023
Merged
6 tasks
@dbanks12 dbanks12 merged commit 7e44765 into master Apr 29, 2023
@dbanks12 dbanks12 deleted the db/clang-format-tidy-setup branch April 29, 2023 16:26
ludamad pushed a commit that referenced this pull request Jul 14, 2023
@Maddiaa0
exp: fix alpine versioning (#415)
623b55a 
Co-authored-by: cheethas <addaboy@gmail.com>
This was referenced Jul 25, 2023
Closed
Closed
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@Maddiaa0
exp: fix alpine versioning (#415)
18d26d9 
Co-authored-by: cheethas <addaboy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludamad ludamad ludamad approved these changes

@iAmMichaelConnor iAmMichaelConnor Awaiting requested review from iAmMichaelConnor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dbanks12 @ludamad